Skip to content

Commit 6445307

Browse files
jonathansaminesjasnell
authored andcommitted
test: fix strictEqual arguments order
Fix strictEqual assertion arguments order to conform to the function signature in buffer tests PR-URL: #23486 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent b61d31a commit 6445307

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

test/parallel/test-buffer-readuint.js

+18-18
Original file line numberDiff line numberDiff line change
@@ -47,37 +47,37 @@ const assert = require('assert');
4747
// Test 8 bit unsigned integers
4848
{
4949
const data = Buffer.from([0xff, 0x2a, 0x2a, 0x2a]);
50-
assert.strictEqual(255, data.readUInt8(0));
51-
assert.strictEqual(42, data.readUInt8(1));
52-
assert.strictEqual(42, data.readUInt8(2));
53-
assert.strictEqual(42, data.readUInt8(3));
50+
assert.strictEqual(data.readUInt8(0), 255);
51+
assert.strictEqual(data.readUInt8(1), 42);
52+
assert.strictEqual(data.readUInt8(2), 42);
53+
assert.strictEqual(data.readUInt8(3), 42);
5454
}
5555

5656
// Test 16 bit unsigned integers
5757
{
5858
const data = Buffer.from([0x00, 0x2a, 0x42, 0x3f]);
59-
assert.strictEqual(0x2a, data.readUInt16BE(0));
60-
assert.strictEqual(0x2a42, data.readUInt16BE(1));
61-
assert.strictEqual(0x423f, data.readUInt16BE(2));
62-
assert.strictEqual(0x2a00, data.readUInt16LE(0));
63-
assert.strictEqual(0x422a, data.readUInt16LE(1));
64-
assert.strictEqual(0x3f42, data.readUInt16LE(2));
59+
assert.strictEqual(data.readUInt16BE(0), 0x2a);
60+
assert.strictEqual(data.readUInt16BE(1), 0x2a42);
61+
assert.strictEqual(data.readUInt16BE(2), 0x423f);
62+
assert.strictEqual(data.readUInt16LE(0), 0x2a00);
63+
assert.strictEqual(data.readUInt16LE(1), 0x422a);
64+
assert.strictEqual(data.readUInt16LE(2), 0x3f42);
6565

6666
data[0] = 0xfe;
6767
data[1] = 0xfe;
68-
assert.strictEqual(0xfefe, data.readUInt16BE(0));
69-
assert.strictEqual(0xfefe, data.readUInt16LE(0));
68+
assert.strictEqual(data.readUInt16BE(0), 0xfefe);
69+
assert.strictEqual(data.readUInt16LE(0), 0xfefe);
7070
}
7171

7272
// Test 32 bit unsigned integers
7373
{
7474
const data = Buffer.from([0x32, 0x65, 0x42, 0x56, 0x23, 0xff]);
75-
assert.strictEqual(0x32654256, data.readUInt32BE(0));
76-
assert.strictEqual(0x65425623, data.readUInt32BE(1));
77-
assert.strictEqual(0x425623ff, data.readUInt32BE(2));
78-
assert.strictEqual(0x56426532, data.readUInt32LE(0));
79-
assert.strictEqual(0x23564265, data.readUInt32LE(1));
80-
assert.strictEqual(0xff235642, data.readUInt32LE(2));
75+
assert.strictEqual(data.readUInt32BE(0), 0x32654256);
76+
assert.strictEqual(data.readUInt32BE(1), 0x65425623);
77+
assert.strictEqual(data.readUInt32BE(2), 0x425623ff);
78+
assert.strictEqual(data.readUInt32LE(0), 0x56426532);
79+
assert.strictEqual(data.readUInt32LE(1), 0x23564265);
80+
assert.strictEqual(data.readUInt32LE(2), 0xff235642);
8181
}
8282

8383
// Test UInt

0 commit comments

Comments
 (0)