Skip to content

Commit 644989c

Browse files
JLHwungMylesBorins
authored andcommitted
fs: use Number::New since all fields are uint64_t
PR-URL: #16705 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 925e58f commit 644989c

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

src/node_file.cc

+7-20
Original file line numberDiff line numberDiff line change
@@ -436,39 +436,26 @@ Local<Value> BuildStatsObject(Environment* env, const uv_stat_t* s) {
436436
// We need to check the return value of Number::New() and Date::New()
437437
// and make sure that we bail out when V8 returns an empty handle.
438438

439-
// Unsigned integers. It does not actually seem to be specified whether
440-
// uid and gid are unsigned or not, but in practice they are unsigned,
441-
// and Node’s (F)Chown functions do check their arguments for unsignedness.
439+
// Numbers.
442440
#define X(name) \
443-
Local<Value> name = Integer::NewFromUnsigned(env->isolate(), s->st_##name); \
441+
Local<Value> name = Number::New(env->isolate(), \
442+
static_cast<double>(s->st_##name)); \
444443
if (name.IsEmpty()) \
445444
return Local<Object>(); \
446445

447446
X(uid)
448447
X(gid)
449-
# if defined(__POSIX__)
450-
X(blksize)
451-
# else
452-
Local<Value> blksize = Undefined(env->isolate());
453-
# endif
448+
X(ino)
449+
X(size)
454450
X(dev)
455451
X(mode)
456452
X(nlink)
457453
X(rdev)
458-
#undef X
459-
460-
// Numbers.
461-
#define X(name) \
462-
Local<Value> name = Number::New(env->isolate(), \
463-
static_cast<double>(s->st_##name)); \
464-
if (name.IsEmpty()) \
465-
return Local<Object>(); \
466-
467-
X(ino)
468-
X(size)
469454
# if defined(__POSIX__)
455+
X(blksize)
470456
X(blocks)
471457
# else
458+
Local<Value> blksize = Undefined(env->isolate());
472459
Local<Value> blocks = Undefined(env->isolate());
473460
# endif
474461
#undef X

0 commit comments

Comments
 (0)