Skip to content

Commit 6489a5b

Browse files
lianxuifytargos
authored andcommitted
module: fix memory leak when require error occurs
Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: #32836 PR-URL: #32837 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
1 parent bb1481f commit 6489a5b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/internal/modules/cjs/loader.js

+7
Original file line numberDiff line numberDiff line change
@@ -882,6 +882,13 @@ Module._load = function(request, parent, isMain) {
882882
delete Module._cache[filename];
883883
if (parent !== undefined) {
884884
delete relativeResolveCache[relResolveCacheIdentifier];
885+
const children = parent && parent.children;
886+
if (ArrayIsArray(children)) {
887+
const index = children.indexOf(module);
888+
if (index !== -1) {
889+
children.splice(index, 1);
890+
}
891+
}
885892
}
886893
}
887894
}

test/sequential/test-module-loading.js

-3
Original file line numberDiff line numberDiff line change
@@ -302,17 +302,14 @@ assert.throws(
302302
}
303303
},
304304
'fixtures/path.js': {},
305-
'fixtures/throws_error.js': {},
306305
'fixtures/registerExt.test': {},
307306
'fixtures/registerExt.hello.world': {},
308307
'fixtures/registerExt2.test': {},
309308
'fixtures/module-load-order/file1': {},
310309
'fixtures/module-load-order/file2.js': {},
311-
'fixtures/module-load-order/file3.node': {},
312310
'fixtures/module-load-order/file4.reg': {},
313311
'fixtures/module-load-order/file5.reg2': {},
314312
'fixtures/module-load-order/file6/index.js': {},
315-
'fixtures/module-load-order/file7/index.node': {},
316313
'fixtures/module-load-order/file8/index.reg': {},
317314
'fixtures/module-load-order/file9/index.reg2': {},
318315
'fixtures/module-require/parent/index.js': {

0 commit comments

Comments
 (0)