@@ -35,6 +35,7 @@ so that you can make the actual changes. This is where we will start.
35
35
* [ CI Testing] ( #ci-testing )
36
36
* [ Waiting Until the Pull Request Gets Landed] ( #waiting-until-the-pull-request-gets-landed )
37
37
* [ Check Out the Collaborator Guide] ( #check-out-the-collaborator-guide )
38
+ * [ Appendix: Subsystems] ( #appendix-subsystems )
38
39
39
40
## Dependencies
40
41
@@ -171,9 +172,9 @@ A good commit message should describe what changed and why.
171
172
less, and no more than 72 characters)
172
173
* be entirely in lowercase with the exception of proper nouns, acronyms, and
173
174
the words that refer to code, like function/variable names
174
- * be prefixed with the name of the changed subsystem and start with an
175
- imperative verb. Check the output of ` git log --oneline files/you/changed ` to
176
- find out what subsystems your changes touch.
175
+ * be prefixed with the name of the changed [ subsystem] ( #appendix-subsystems )
176
+ and start with an imperative verb. Check the output of `git log --oneline
177
+ files/you/changed` to find out what subsystems your changes touch.
177
178
178
179
Examples:
179
180
* ` net: add localAddress and localPort to Socket `
@@ -603,6 +604,17 @@ widely used, so don't be discouraged!
603
604
If you want to know more about the code review and the landing process, see the
604
605
[ Collaborator Guide] [ ] .
605
606
607
+ ### Appendix: Subsystems
608
+
609
+ * ` lib/*.js ` (` assert ` , ` buffer ` , etc.)
610
+ * ` build `
611
+ * ` doc `
612
+ * ` lib / src `
613
+ * ` test `
614
+ * ` tools `
615
+
616
+ More than one subsystem may be valid for any particular issue or pull request.
617
+
606
618
[ Building guide ] : ../../../BUILDING.md
607
619
[ CI (Continuous Integration) test run ] : #ci-testing
608
620
[ Code of Conduct ] : https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
0 commit comments