Skip to content

Commit 65c136f

Browse files
addaleaxBridgeAR
authored andcommittedJan 10, 2019
worker: partially remove --experimental-worker flag
This is a trimmed-down version of 63d4cae that avoids backporting pain for v11.x. The remainder of the original commit can be cherry-picked later, once other PRs have been backported first. PR-URL: #25404 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> --- Original commit message --- Having an experimental feature behind a flag makes change if we are expecting significant breaking changes to its API. Since the Worker API has been essentially stable since its initial introduction, and no noticeable doubt about possibly not keeping the feature around has been voiced, removing the flag and thereby reducing the barrier to experimentation, and consequently receiving feedback on the implementation, seems like a good idea. Refs: #25361 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 7bb7b9a commit 65c136f

File tree

53 files changed

+15
-68
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+15
-68
lines changed
 

‎benchmark/misc/startup.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
1010
script: ['benchmark/fixtures/require-cachable', 'test/fixtures/semicolon'],
1111
mode: ['process', 'worker']
1212
}, {
13-
flags: ['--expose-internals', '--experimental-worker'] // for workers
13+
flags: ['--expose-internals']
1414
});
1515

1616
function spawnProcess(script) {

‎benchmark/worker/echo.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
77
payload: ['string', 'object'],
88
sendsPerBroadcast: [1, 10],
99
n: [1e5]
10-
}, { flags: ['--experimental-worker'] });
10+
});
1111

1212
const workerPath = path.resolve(__dirname, '..', 'fixtures', 'echo.worker.js');
1313

0 commit comments

Comments
 (0)