Skip to content

Commit 668437c

Browse files
authored
deps: V8: cherry-pick b60a03df4ceb
Original commit message: [api] mark v8::Script and v8::UnboundScript as v8::Data v8::UnboundModuleScript and v8::Module are already v8::Data. Mark v8::Script and v8::UnboundScript as v8::Data so that they can be used in other V8 APIs that takes v8::Data. Refs: #48510 Bug: v8:14120 Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#89727} Refs: v8/v8@b60a03d PR-URL: #49491 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
1 parent e4d1259 commit 668437c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.16',
39+
'v8_embedder_string': '-node.17',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-script.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class V8_EXPORT ScriptOrModule {
5555
/**
5656
* A compiled JavaScript script, not yet tied to a Context.
5757
*/
58-
class V8_EXPORT UnboundScript {
58+
class V8_EXPORT UnboundScript : public Data {
5959
public:
6060
/**
6161
* Binds the script to the currently entered context.
@@ -320,7 +320,7 @@ class V8_EXPORT Module : public Data {
320320
* A compiled JavaScript script, tied to a Context which was active when the
321321
* script was compiled.
322322
*/
323-
class V8_EXPORT Script {
323+
class V8_EXPORT Script : public Data {
324324
public:
325325
/**
326326
* A shorthand for ScriptCompiler::Compile().

0 commit comments

Comments
 (0)