Skip to content

Commit 668ab61

Browse files
Julien Gillirvagg
Julien Gilli
authored andcommitted
net: do not set V4MAPPED on FreeBSD
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent fee915c commit 668ab61

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

doc/api/dns.markdown

+3-2
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,9 @@ The following flags can be passed as hints to `dns.lookup`.
267267
of addresses supported by the current system. For example, IPv4 addresses
268268
are only returned if the current system has at least one IPv4 address
269269
configured. Loopback addresses are not considered.
270-
- `dns.V4MAPPED`: If the IPv6 family was specified, but no IPv6 addresses
271-
were found, then return IPv4 mapped IPv6 addresses.
270+
- `dns.V4MAPPED`: If the IPv6 family was specified, but no IPv6 addresses were
271+
found, then return IPv4 mapped IPv6 addresses. Note that it is not supported
272+
on some operating systems (e.g FreeBSD 10.1).
272273

273274
## Implementation considerations
274275

lib/net.js

+10-2
Original file line numberDiff line numberDiff line change
@@ -941,8 +941,16 @@ function lookupAndConnect(self, options) {
941941
hints: 0
942942
};
943943

944-
if (dnsopts.family !== 4 && dnsopts.family !== 6)
945-
dnsopts.hints = dns.ADDRCONFIG | dns.V4MAPPED;
944+
if (dnsopts.family !== 4 && dnsopts.family !== 6) {
945+
dnsopts.hints = dns.ADDRCONFIG;
946+
// The AI_V4MAPPED hint is not supported on FreeBSD, and getaddrinfo
947+
// returns EAI_BADFLAGS. However, it seems to be supported on most other
948+
// systems. See
949+
// http://lists.freebsd.org/pipermail/freebsd-bugs/2008-February/028260.html
950+
// for more information on the lack of support for FreeBSD.
951+
if (process.platform !== 'freebsd')
952+
dnsopts.hints |= dns.V4MAPPED;
953+
}
946954

947955
debug('connect: find host ' + host);
948956
debug('connect: dns options', dnsopts);

0 commit comments

Comments
 (0)