Skip to content

Commit 66f6a2a

Browse files
targosRafaelGSS
authored andcommitted
deps: V8: cherry-pick 9812cb486e2b
Original commit message: [api] Remove template id from Local constructor According to GCC version 14, this is deprecated in C++20. Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#95084} Refs: v8/v8@9812cb4 PR-URL: #53966 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 876e7b3 commit 66f6a2a

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.16',
39+
'v8_embedder_string': '-node.17',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-local-handle.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,7 @@ class V8_TRIVIAL_ABI Local : public LocalBase<T>,
398398
explicit Local(const Local<T>& other, no_checking_tag do_not_check)
399399
: LocalBase<T>(other), StackAllocated(do_not_check) {}
400400

401-
V8_INLINE explicit Local<T>(const LocalBase<T>& other)
402-
: LocalBase<T>(other) {}
401+
V8_INLINE explicit Local(const LocalBase<T>& other) : LocalBase<T>(other) {}
403402

404403
V8_INLINE static Local<T> FromSlot(internal::Address* slot) {
405404
return Local<T>(LocalBase<T>::FromSlot(slot));

0 commit comments

Comments
 (0)