Skip to content

Commit 6bce6f6

Browse files
targosnodejs-github-bot
authored andcommitted
Revert "deps: remove bogus V8 DCHECK"
This reverts commit fba06eb. PR-URL: #54682 Refs: v8/v8@12.8.374.22...12.8.374.31 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 123bb4c commit 6bce6f6

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.14',
39+
'v8_embedder_string': '-node.15',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/ast/scopes.cc

+1
Original file line numberDiff line numberDiff line change
@@ -2713,6 +2713,7 @@ void Scope::AllocateScopeInfosRecursively(
27132713

27142714
// Allocate ScopeInfos for inner scopes.
27152715
for (Scope* scope = inner_scope_; scope != nullptr; scope = scope->sibling_) {
2716+
DCHECK_GT(scope->UniqueIdInScript(), UniqueIdInScript());
27162717
DCHECK_IMPLIES(scope->sibling_, scope->sibling_->UniqueIdInScript() !=
27172718
scope->UniqueIdInScript());
27182719
if (!scope->is_function_scope() ||

0 commit comments

Comments
 (0)