Skip to content

Commit 6e42433

Browse files
authored
Revert "build: avoid compiling with VS v17.12"
This reverts commit 542f252. PR-URL: #56151 Refs: nodejs/build#3963 Refs: #55930 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent ac7fea6 commit 6e42433

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

vcbuild.bat

+1-10
Original file line numberDiff line numberDiff line change
@@ -292,19 +292,10 @@ goto exit
292292
@rem Visual Studio v17.10 has a bug that causes the build to fail.
293293
@rem Check if the version is v17.10 and exit if it is.
294294
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
295-
if %errorlevel% neq 1 (
295+
if %errorlevel% neq 1 (
296296
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
297297
goto exit
298298
)
299-
@rem Same applies to v17.12 for MSVC.
300-
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
301-
if %errorlevel% neq 1 (
302-
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
303-
if not defined clang_cl (
304-
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
305-
goto exit
306-
)
307-
)
308299

309300
@rem check if the clang-cl build is requested
310301
if not defined clang_cl goto clang-skip

0 commit comments

Comments
 (0)