Skip to content

Commit 6f95f01

Browse files
BridgeARTrott
BridgeAR
authored and
Trott
committed
deps: deactivate failing tests corresponding to experimental features
This comments out three tests that consistently fail on v13.x. The test can be activated again in case the necessary code change lands on v13.x for the tests to pass. PR-URL: #31289 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent 4a702c3 commit 6f95f01

File tree

1 file changed

+146
-146
lines changed

1 file changed

+146
-146
lines changed

‎deps/v8/test/cctest/interpreter/test-bytecode-generator.cc

+146-146
Original file line numberDiff line numberDiff line change
@@ -2884,129 +2884,129 @@ TEST(PrivateAccessorAccess) {
28842884
i::FLAG_harmony_private_methods = old_methods_flag;
28852885
}
28862886

2887-
TEST(StaticPrivateMethodDeclaration) {
2888-
bool old_methods_flag = i::FLAG_harmony_private_methods;
2889-
i::FLAG_harmony_private_methods = true;
2890-
InitializedIgnitionHandleScope scope;
2891-
BytecodeExpectationsPrinter printer(CcTest::isolate());
2892-
2893-
const char* snippets[] = {
2894-
"{\n"
2895-
" class A {\n"
2896-
" static #a() { return 1; }\n"
2897-
" }\n"
2898-
"}\n",
2899-
2900-
"{\n"
2901-
" class A {\n"
2902-
" static get #a() { return 1; }\n"
2903-
" }\n"
2904-
"}\n",
2905-
2906-
"{\n"
2907-
" class A {\n"
2908-
" static set #a(val) { }\n"
2909-
" }\n"
2910-
"}\n",
2911-
2912-
"{\n"
2913-
" class A {\n"
2914-
" static get #a() { return 1; }\n"
2915-
" static set #a(val) { }\n"
2916-
" }\n"
2917-
"}\n",
2918-
2919-
"{\n"
2920-
" class A {\n"
2921-
" static #a() { }\n"
2922-
" #b() { }\n"
2923-
" }\n"
2924-
"}\n"};
2925-
2926-
CHECK(CompareTexts(BuildActual(printer, snippets),
2927-
LoadGolden("StaticPrivateMethodDeclaration.golden")));
2928-
i::FLAG_harmony_private_methods = old_methods_flag;
2929-
}
2930-
2931-
TEST(StaticPrivateMethodAccess) {
2932-
bool old_methods_flag = i::FLAG_harmony_private_methods;
2933-
i::FLAG_harmony_private_methods = true;
2934-
InitializedIgnitionHandleScope scope;
2935-
BytecodeExpectationsPrinter printer(CcTest::isolate());
2936-
printer.set_wrap(false);
2937-
printer.set_test_function_name("test");
2938-
2939-
const char* snippets[] = {
2940-
"class A {\n"
2941-
" static #a() { return 1; }\n"
2942-
" static test() { return this.#a(); }\n"
2943-
"}\n"
2944-
"\n"
2945-
"var test = A.test;\n"
2946-
"test();\n",
2947-
2948-
"class B {\n"
2949-
" static #b() { return 1; }\n"
2950-
" static test() { this.#b = 1; }\n"
2951-
"}\n"
2952-
"\n"
2953-
"var test = B.test;\n"
2954-
"test();\n",
2955-
2956-
"class C {\n"
2957-
" static #c() { return 1; }\n"
2958-
" static test() { this.#c++; }\n"
2959-
"}\n"
2960-
"\n"
2961-
"var test = C.test;\n"
2962-
"test();\n",
2963-
2964-
"class D {\n"
2965-
" static get #d() { return 1; }\n"
2966-
" static set #d(val) { }\n"
2967-
"\n"
2968-
" static test() {\n"
2969-
" this.#d++;\n"
2970-
" this.#d = 1;\n"
2971-
" return this.#d;\n"
2972-
" }\n"
2973-
"}\n"
2974-
"\n"
2975-
"var test = D.test;\n"
2976-
"test();\n",
2977-
2978-
"class E {\n"
2979-
" static get #e() { return 1; }\n"
2980-
" static test() { this.#e++; }\n"
2981-
"}\n"
2982-
"var test = E.test;\n"
2983-
"test();\n",
2984-
2985-
"class F {\n"
2986-
" static set #f(val) { }\n"
2987-
" static test() { this.#f++; }\n"
2988-
"}\n"
2989-
"var test = F.test;\n"
2990-
"test();\n",
2991-
2992-
"class G {\n"
2993-
" static get #d() { return 1; }\n"
2994-
" static test() { this.#d = 1; }\n"
2995-
"}\n"
2996-
"var test = G.test;\n"
2997-
"test();\n",
2998-
2999-
"class H {\n"
3000-
" set #h(val) { }\n"
3001-
" static test() { this.#h; }\n"
3002-
"}\n"
3003-
"var test = H.test;\n"
3004-
"test();\n"};
3005-
3006-
CHECK(CompareTexts(BuildActual(printer, snippets),
3007-
LoadGolden("StaticPrivateMethodAccess.golden")));
3008-
i::FLAG_harmony_private_methods = old_methods_flag;
3009-
}
2887+
// TEST(StaticPrivateMethodDeclaration) {
2888+
// bool old_methods_flag = i::FLAG_harmony_private_methods;
2889+
// i::FLAG_harmony_private_methods = true;
2890+
// InitializedIgnitionHandleScope scope;
2891+
// BytecodeExpectationsPrinter printer(CcTest::isolate());
2892+
2893+
// const char* snippets[] = {
2894+
// "{\n"
2895+
// " class A {\n"
2896+
// " static #a() { return 1; }\n"
2897+
// " }\n"
2898+
// "}\n",
2899+
2900+
// "{\n"
2901+
// " class A {\n"
2902+
// " static get #a() { return 1; }\n"
2903+
// " }\n"
2904+
// "}\n",
2905+
2906+
// "{\n"
2907+
// " class A {\n"
2908+
// " static set #a(val) { }\n"
2909+
// " }\n"
2910+
// "}\n",
2911+
2912+
// "{\n"
2913+
// " class A {\n"
2914+
// " static get #a() { return 1; }\n"
2915+
// " static set #a(val) { }\n"
2916+
// " }\n"
2917+
// "}\n",
2918+
2919+
// "{\n"
2920+
// " class A {\n"
2921+
// " static #a() { }\n"
2922+
// " #b() { }\n"
2923+
// " }\n"
2924+
// "}\n"};
2925+
2926+
// CHECK(CompareTexts(BuildActual(printer, snippets),
2927+
// LoadGolden("StaticPrivateMethodDeclaration.golden")));
2928+
// i::FLAG_harmony_private_methods = old_methods_flag;
2929+
// }
2930+
2931+
// TEST(StaticPrivateMethodAccess) {
2932+
// bool old_methods_flag = i::FLAG_harmony_private_methods;
2933+
// i::FLAG_harmony_private_methods = true;
2934+
// InitializedIgnitionHandleScope scope;
2935+
// BytecodeExpectationsPrinter printer(CcTest::isolate());
2936+
// printer.set_wrap(false);
2937+
// printer.set_test_function_name("test");
2938+
2939+
// const char* snippets[] = {
2940+
// "class A {\n"
2941+
// " static #a() { return 1; }\n"
2942+
// " static test() { return this.#a(); }\n"
2943+
// "}\n"
2944+
// "\n"
2945+
// "var test = A.test;\n"
2946+
// "test();\n",
2947+
2948+
// "class B {\n"
2949+
// " static #b() { return 1; }\n"
2950+
// " static test() { this.#b = 1; }\n"
2951+
// "}\n"
2952+
// "\n"
2953+
// "var test = B.test;\n"
2954+
// "test();\n",
2955+
2956+
// "class C {\n"
2957+
// " static #c() { return 1; }\n"
2958+
// " static test() { this.#c++; }\n"
2959+
// "}\n"
2960+
// "\n"
2961+
// "var test = C.test;\n"
2962+
// "test();\n",
2963+
2964+
// "class D {\n"
2965+
// " static get #d() { return 1; }\n"
2966+
// " static set #d(val) { }\n"
2967+
// "\n"
2968+
// " static test() {\n"
2969+
// " this.#d++;\n"
2970+
// " this.#d = 1;\n"
2971+
// " return this.#d;\n"
2972+
// " }\n"
2973+
// "}\n"
2974+
// "\n"
2975+
// "var test = D.test;\n"
2976+
// "test();\n",
2977+
2978+
// "class E {\n"
2979+
// " static get #e() { return 1; }\n"
2980+
// " static test() { this.#e++; }\n"
2981+
// "}\n"
2982+
// "var test = E.test;\n"
2983+
// "test();\n",
2984+
2985+
// "class F {\n"
2986+
// " static set #f(val) { }\n"
2987+
// " static test() { this.#f++; }\n"
2988+
// "}\n"
2989+
// "var test = F.test;\n"
2990+
// "test();\n",
2991+
2992+
// "class G {\n"
2993+
// " static get #d() { return 1; }\n"
2994+
// " static test() { this.#d = 1; }\n"
2995+
// "}\n"
2996+
// "var test = G.test;\n"
2997+
// "test();\n",
2998+
2999+
// "class H {\n"
3000+
// " set #h(val) { }\n"
3001+
// " static test() { this.#h; }\n"
3002+
// "}\n"
3003+
// "var test = H.test;\n"
3004+
// "test();\n"};
3005+
3006+
// CHECK(CompareTexts(BuildActual(printer, snippets),
3007+
// LoadGolden("StaticPrivateMethodAccess.golden")));
3008+
// i::FLAG_harmony_private_methods = old_methods_flag;
3009+
// }
30103010

30113011
TEST(PrivateAccessorDeclaration) {
30123012
bool old_methods_flag = i::FLAG_harmony_private_methods;
@@ -3222,34 +3222,34 @@ TEST(Modules) {
32223222
LoadGolden("Modules.golden")));
32233223
}
32243224

3225-
TEST(AsyncModules) {
3226-
bool previous_top_level_await_flag = i::FLAG_harmony_top_level_await;
3227-
i::FLAG_harmony_top_level_await = true;
3228-
InitializedIgnitionHandleScope scope;
3229-
BytecodeExpectationsPrinter printer(CcTest::isolate());
3230-
printer.set_wrap(false);
3231-
printer.set_module(true);
3232-
printer.set_top_level(true);
3225+
// TEST(AsyncModules) {
3226+
// bool previous_top_level_await_flag = i::FLAG_harmony_top_level_await;
3227+
// i::FLAG_harmony_top_level_await = true;
3228+
// InitializedIgnitionHandleScope scope;
3229+
// BytecodeExpectationsPrinter printer(CcTest::isolate());
3230+
// printer.set_wrap(false);
3231+
// printer.set_module(true);
3232+
// printer.set_top_level(true);
32333233

3234-
const char* snippets[] = {
3235-
"await 42;\n",
3234+
// const char* snippets[] = {
3235+
// "await 42;\n",
32363236

3237-
"await import(\"foo\");\n",
3237+
// "await import(\"foo\");\n",
32383238

3239-
"await 42;\n"
3240-
"async function foo() {\n"
3241-
" await 42;\n"
3242-
"}\n"
3243-
"foo();\n",
3239+
// "await 42;\n"
3240+
// "async function foo() {\n"
3241+
// " await 42;\n"
3242+
// "}\n"
3243+
// "foo();\n",
32443244

3245-
"import * as foo from \"bar\";\n"
3246-
"await import(\"goo\");\n",
3247-
};
3245+
// "import * as foo from \"bar\";\n"
3246+
// "await import(\"goo\");\n",
3247+
// };
32483248

3249-
CHECK(CompareTexts(BuildActual(printer, snippets),
3250-
LoadGolden("AsyncModules.golden")));
3251-
i::FLAG_harmony_top_level_await = previous_top_level_await_flag;
3252-
}
3249+
// CHECK(CompareTexts(BuildActual(printer, snippets),
3250+
// LoadGolden("AsyncModules.golden")));
3251+
// i::FLAG_harmony_top_level_await = previous_top_level_await_flag;
3252+
// }
32533253

32543254
TEST(SuperCallAndSpread) {
32553255
InitializedIgnitionHandleScope scope;

0 commit comments

Comments
 (0)