Skip to content

Commit 706812b

Browse files
digitalinfinityMylesBorins
authored andcommitted
build: skip bin override on windows
PR-URL: #16460 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent c64ed97 commit 706812b

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

configure

+5-2
Original file line numberDiff line numberDiff line change
@@ -1319,7 +1319,9 @@ def configure_inspector(o):
13191319
o['variables']['v8_inspector'] = b(not disable_inspector)
13201320

13211321

1322-
def get_bin_override():
1322+
def make_bin_override():
1323+
if sys.platform == 'win32':
1324+
raise Exception('make_bin_override should not be called on win32.')
13231325
# If the system python is not the python we are running (which should be
13241326
# python 2), then create a directory with a symlink called `python` to our
13251327
# sys.executable. This directory will be prefixed to the PATH, so that
@@ -1426,7 +1428,8 @@ if options.prefix:
14261428

14271429
config = '\n'.join(map('='.join, config.iteritems())) + '\n'
14281430

1429-
bin_override = get_bin_override()
1431+
# On Windows there's no reason to search for a different python binary.
1432+
bin_override = None if sys.platform == 'win32' else make_bin_override()
14301433
if bin_override:
14311434
config = 'export PATH:=' + bin_override + ':$(PATH)\n' + config
14321435

0 commit comments

Comments
 (0)