Skip to content

Commit 706e189

Browse files
committed
fixup: closeEmitted not needed on readable, yet
1 parent b544f97 commit 706e189

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

lib/_stream_readable.js

-4
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,6 @@ function ReadableState(options, stream, isDuplex) {
153153
// Indicates whether the stream has finished destroying.
154154
this.closed = false;
155155

156-
// True if close has been emitted or would have been emitted
157-
// depending on emitClose.
158-
this.closeEmitted = false;
159-
160156
// Crypto is kind of old and crusty. Historically, its default string
161157
// encoding is 'binary' so we have to make this configurable.
162158
// Everything else in the universe uses 'utf8', though.

lib/internal/streams/destroy.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,6 @@ function emitCloseNT(self) {
7676
if (w) {
7777
w.closeEmitted = true;
7878
}
79-
if (r) {
80-
r.closeEmitted = true;
81-
}
8279

8380
if ((w && w.emitClose) || (r && r.emitClose)) {
8481
self.emit('close');
@@ -108,14 +105,13 @@ function undestroy() {
108105
const w = this._writableState;
109106

110107
if (r) {
111-
r.destroyed = false;
112108
r.closed = false;
113-
r.closeEmitted = false;
109+
r.destroyed = false;
114110
r.errored = false;
115-
r.errorEmitted = false;
116111
r.reading = false;
117112
r.ended = false;
118113
r.endEmitted = false;
114+
r.errorEmitted = false;
119115
}
120116

121117
if (w) {

0 commit comments

Comments
 (0)