Skip to content

Commit 70ca26a

Browse files
Emanuel Hoogeveendanielleadams
Emanuel Hoogeveen
authored andcommitted
src: add --max-semi-space-size to the options allowed in NODE_OPTIONS
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 40123a6 commit 70ca26a

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

doc/api/cli.md

+1
Original file line numberDiff line numberDiff line change
@@ -1929,6 +1929,7 @@ V8 options that are allowed are:
19291929
* `--interpreted-frames-native-stack`
19301930
* `--jitless`
19311931
* `--max-old-space-size`
1932+
* `--max-semi-space-size`
19321933
* `--perf-basic-prof-only-functions`
19331934
* `--perf-basic-prof`
19341935
* `--perf-prof-unwinding-info`

src/node_options.cc

+1
Original file line numberDiff line numberDiff line change
@@ -713,6 +713,7 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
713713
"help system profilers to translate JavaScript interpreted frames",
714714
V8Option{}, kAllowedInEnvironment);
715715
AddOption("--max-old-space-size", "", V8Option{}, kAllowedInEnvironment);
716+
AddOption("--max-semi-space-size", "", V8Option{}, kAllowedInEnvironment);
716717
AddOption("--perf-basic-prof", "", V8Option{}, kAllowedInEnvironment);
717718
AddOption("--perf-basic-prof-only-functions",
718719
"",

test/parallel/test-cli-node-options.js

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ expect('--disallow-code-generation-from-strings', 'B\n');
7272
expect('--huge-max-old-generation-size', 'B\n');
7373
expect('--jitless', 'B\n');
7474
expect('--max-old-space-size=0', 'B\n');
75+
expect('--max-semi-space-size=0', 'B\n');
7576
expect('--stack-trace-limit=100',
7677
/(\s*at f \(\[(eval|worker eval)\]:1:\d*\)\r?\n)/,
7778
'(function f() { f(); })();',

0 commit comments

Comments
 (0)