Skip to content

Commit 71fdf96

Browse files
avivkellerd3x0r
authored andcommittedAug 30, 2024
build: update required python version to 3.8
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com> PR-URL: #54358 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent d4310fe commit 71fdf96

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed
 

‎BUILDING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ Consult previous versions of this document for older versions of Node.js:
230230

231231
### Prerequisites
232232

233-
* Python support: the Node.js project supports Python >= 3.6 for building and testing.
233+
* [A supported version of Python][Python versions] for building and testing.
234234
* Memory: at least 8GB of RAM is typically required when compiling with 4 parallel jobs (e.g: `make -j4`)
235235

236236
### Unix and macOS

‎android-configure

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
88
command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
99
command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
1010
command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
11-
command -v python3.7 >/dev/null && exec python3.7 "$0" "$@"
12-
command -v python3.6 >/dev/null && exec python3.6 "$0" "$@"
1311
command -v python3 >/dev/null && exec python3 "$0" "$@"
1412
exec python "$0" "$@"
1513
''' "$0" "$@"
@@ -23,7 +21,7 @@ except ImportError:
2321
from distutils.spawn import find_executable as which
2422

2523
print('Node.js android configure: Found Python {}.{}.{}...'.format(*sys.version_info))
26-
acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
24+
acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8))
2725
if sys.version_info[:2] in acceptable_pythons:
2826
import android_configure
2927
else:

‎configure

+1-3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
1010
command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
1111
command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
1212
command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
13-
command -v python3.7 >/dev/null && exec python3.7 "$0" "$@"
14-
command -v python3.6 >/dev/null && exec python3.6 "$0" "$@"
1513
command -v python3 >/dev/null && exec python3 "$0" "$@"
1614
exec python "$0" "$@"
1715
''' "$0" "$@"
@@ -25,7 +23,7 @@ except ImportError:
2523
from distutils.spawn import find_executable as which
2624

2725
print('Node.js configure: Found Python {}.{}.{}...'.format(*sys.version_info))
28-
acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
26+
acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8))
2927
if sys.version_info[:2] in acceptable_pythons:
3028
import configure
3129
else:

‎configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2127,7 +2127,7 @@ def make_bin_override():
21272127
if sys.platform == 'win32':
21282128
raise Exception('make_bin_override should not be called on win32.')
21292129
# If the system python is not the python we are running (which should be
2130-
# python 3), then create a directory with a symlink called `python` to our
2130+
# python 3.8+), then create a directory with a symlink called `python` to our
21312131
# sys.executable. This directory will be prefixed to the PATH, so that
21322132
# other tools that shell out to `python` will use the appropriate python
21332133

‎pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ exclude = [
77
"tools/eslint/node_modules",
88
]
99
line-length = 172
10-
target-version = "py37"
10+
target-version = "py38"
1111

1212
[tool.ruff.lint]
1313
select = [

0 commit comments

Comments
 (0)
Please sign in to comment.