Skip to content

Commit 73b38bf

Browse files
cjihrigmarco-ippolito
authored andcommitted
test_runner: remove redundant report call
This commit removes a redundant call to `reportStarted()`. It is redundant because a few lines down, `subtest.finalize()` is called. `finalize()` will find the first test that is ready to report its data, and then call `report()`, which also calls `reportStarted()`. This will trigger the `'test:start'` as high up the test tree as necessary. PR-URL: #52089 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
1 parent f8362b0 commit 73b38bf

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/internal/test_runner/test.js

-4
Original file line numberDiff line numberDiff line change
@@ -416,10 +416,6 @@ class Test extends AsyncResource {
416416
return;
417417
}
418418

419-
if (i === 1 && this.parent !== null) {
420-
this.reportStarted();
421-
}
422-
423419
// Report the subtest's results and remove it from the ready map.
424420
subtest.finalize();
425421
this.readySubtests.delete(i);

0 commit comments

Comments
 (0)