Skip to content

Commit 7463a7f

Browse files
Trottrvagg
authored andcommitted
doc: revise author ready explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
1 parent 230eb0d commit 7463a7f

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

COLLABORATOR_GUIDE.md

+9-6
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,15 @@ issues and pull requests can always be re-opened if necessary.
6969

7070
### Author ready pull requests
7171

72-
A pull request that is still awaiting the minimum review time is considered
73-
_author ready_ as soon as the CI has been started, it has at least two approvals
74-
(one Collaborator approval is enough if the pull request has been open for more
75-
than 7 days), and it has no outstanding review comments. Please always make sure
76-
to add the `author ready` label to the PR in that case and remove it again as
77-
soon as that condition is not met anymore.
72+
A pull request is _author ready_ when:
73+
74+
* There is a CI run in progress or completed.
75+
* There are at least two Collaborator approvals, or at least one approval if the
76+
pull request is older than 7 days.
77+
* There are no outstanding review comments.
78+
79+
Please always add the `author ready` label to the PR in that case. Please always
80+
remove it again as soon as the conditions are not met anymore.
7881

7982
### Handling own pull requests
8083

0 commit comments

Comments
 (0)