Skip to content

Commit 762679e

Browse files
danbevtargos
authored andcommitted
build: make benchmark/napi all prereq order-only
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 90872c4 commit 762679e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

+4-4
Original file line numberDiff line numberDiff line change
@@ -308,19 +308,19 @@ test-valgrind: all
308308
test-check-deopts: all
309309
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential
310310

311-
benchmark/napi/function_call/build/Release/binding.node: all \
311+
benchmark/napi/function_call/build/Release/binding.node: \
312312
benchmark/napi/function_call/napi_binding.c \
313313
benchmark/napi/function_call/binding.cc \
314-
benchmark/napi/function_call/binding.gyp
314+
benchmark/napi/function_call/binding.gyp | all
315315
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
316316
--python="$(PYTHON)" \
317317
--directory="$(shell pwd)/benchmark/napi/function_call" \
318318
--nodedir="$(shell pwd)"
319319

320-
benchmark/napi/function_args/build/Release/binding.node: all \
320+
benchmark/napi/function_args/build/Release/binding.node: \
321321
benchmark/napi/function_args/napi_binding.c \
322322
benchmark/napi/function_args/binding.cc \
323-
benchmark/napi/function_args/binding.gyp
323+
benchmark/napi/function_args/binding.gyp | all
324324
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
325325
--python="$(PYTHON)" \
326326
--directory="$(shell pwd)/benchmark/napi/function_args" \

0 commit comments

Comments
 (0)