Skip to content

Commit 764085a

Browse files
targosRafaelGSS
authored andcommitted
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 582ff50 commit 764085a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.0',
40+
'v8_embedder_string': '-node.1',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/src/base/macros.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -368,9 +368,9 @@ bool is_inbounds(float_t v) {
368368
// Setup for Windows shared library export.
369369
#define V8_EXPORT_ENUM
370370
#ifdef BUILDING_V8_SHARED_PRIVATE
371-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
371+
#define V8_EXPORT_PRIVATE
372372
#elif USING_V8_SHARED_PRIVATE
373-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
373+
#define V8_EXPORT_PRIVATE
374374
#else
375375
#define V8_EXPORT_PRIVATE
376376
#endif // BUILDING_V8_SHARED
@@ -380,8 +380,8 @@ bool is_inbounds(float_t v) {
380380
// Setup for Linux shared library export.
381381
#if V8_HAS_ATTRIBUTE_VISIBILITY
382382
#ifdef BUILDING_V8_SHARED_PRIVATE
383-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
384-
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
383+
#define V8_EXPORT_PRIVATE
384+
#define V8_EXPORT_ENUM
385385
#else
386386
#define V8_EXPORT_PRIVATE
387387
#define V8_EXPORT_ENUM

0 commit comments

Comments
 (0)