crypto: fix crypto.verify callback invocation with a private keyobject

panva · panva · commit 77667dfd76f8 · 2021-03-18T11:19:55.000+01:00
fixes #37794
diff --git a/src/crypto/crypto_sig.cc b/src/crypto/crypto_sig.cc
@@ -847,7 +847,7 @@ bool SignTraits::DeriveBits(
       }
       break;
     case SignConfiguration::kVerify:
-      CHECK_EQ(params.key->GetKeyType(), kKeyTypePublic);
+      CHECK(params.key->GetKeyType() != kKeyTypeSecret);
       if (!EVP_DigestVerifyInit(
               context.get(),
               &ctx,
diff --git a/test/parallel/test-crypto-async-sign-verify.js b/test/parallel/test-crypto-async-sign-verify.js
@@ -52,7 +52,9 @@ function test(
     }));
   }
 
-  for (const key of [publicPem, publicKey, publicDer]) {
+  const verifyInputs = [
+    publicPem, publicKey, publicDer, privatePem, privateKey, privateDer];
+  for (const key of verifyInputs) {
     crypto.verify(algorithm, data, key, expected, common.mustSucceed(
       (verified) => assert.strictEqual(verified, true)));
 

Original file line number	Diff line number	Diff line change
`@@ -847,7 +847,7 @@ bool SignTraits::DeriveBits(`
`847`	`847`	`}`
`848`	`848`	`break;`
`849`	`849`	`case SignConfiguration::kVerify:`
`850`		`- CHECK_EQ(params.key->GetKeyType(), kKeyTypePublic);`
	`850`	`+ CHECK(params.key->GetKeyType() != kKeyTypeSecret);`
`851`	`851`	`if (!EVP_DigestVerifyInit(`
`852`	`852`	`context.get(),`
`853`	`853`	`&ctx,`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,9 @@ function test(`
`52`	`52`	`}));`
`53`	`53`	`}`
`54`	`54`
`55`		`- for (const key of [publicPem, publicKey, publicDer]) {`
	`55`	`+ const verifyInputs = [`
	`56`	`+ publicPem, publicKey, publicDer, privatePem, privateKey, privateDer];`
	`57`	`+ for (const key of verifyInputs) {`
`56`	`58`	`crypto.verify(algorithm, data, key, expected, common.mustSucceed(`
`57`	`59`	`(verified) => assert.strictEqual(verified, true)));`
`58`	`60`