Skip to content

Commit 7da45f8

Browse files
gr2mmhdawson
authored andcommitted
build: ignore empty folders in test-addons
Fixes: #14843 PR-URL: #16031 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4957726 commit 7da45f8

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,10 @@ test/addons/.buildstamp: config.gypi \
267267
test/addons/.docbuildstamp
268268
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
269269
# embedded addons have been generated from the documentation.
270+
# Ignore folders without binding.gyp (#14843)
270271
@for dirname in test/addons/*/; do \
272+
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
273+
continue; fi ; \
271274
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
272275
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
273276
--loglevel=$(LOGLEVEL) rebuild \

0 commit comments

Comments
 (0)