Skip to content

Commit 7e4b47f

Browse files
joaocgreisrvagg
authored andcommitted
build,win: fix node.exe resource version
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: #2963 PR-URL: #3053 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
1 parent 64459c0 commit 7e4b47f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/res/node.rc

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ BEGIN
5353
VALUE "CompanyName", "Joyent, Inc"
5454
VALUE "ProductName", "Node.js"
5555
VALUE "FileDescription", "Evented I/O for V8 JavaScript"
56-
VALUE "FileVersion", NODE_VERSION_STRING
57-
VALUE "ProductVersion", NODE_VERSION_STRING
56+
VALUE "FileVersion", NODE_EXE_VERSION
57+
VALUE "ProductVersion", NODE_EXE_VERSION
5858
VALUE "OriginalFilename", "node.exe"
5959
VALUE "InternalName", "node"
6060
VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."

0 commit comments

Comments
 (0)