Skip to content

Commit 8002192

Browse files
orangemochajoaocgreis
authored andcommitted
win: manifest node.exe for Windows 8.1
This is a port of 03e9352 . Original commit message: Adding a compatibility section to node.exe embedded manifest so that Node is declared explicitly compatible with Windows 8.1. Required so that os.release() can return the correct version on Windows 8.1. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx Reviewed-by: Trevor Norris <trev.norris@gmail.com> PR-URL: #2838 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
1 parent e669b27 commit 8002192

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

node.gyp

+6
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,12 @@
324324
],
325325
}],
326326
],
327+
'msvs_settings': {
328+
'VCManifestTool': {
329+
'EmbedManifest': 'true',
330+
'AdditionalManifestFiles': 'src/res/node.exe.extra.manifest'
331+
}
332+
},
327333
},
328334
# generate ETW header and resource files
329335
{

src/res/node.exe.extra.manifest

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
2+
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
3+
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
4+
<application>
5+
<!-- Windows 8.1 -->
6+
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
7+
<!-- Windows 8 -->
8+
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
9+
<!-- Windows 7 -->
10+
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
11+
<!-- Windows Vista -->
12+
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
13+
</application>
14+
</compatibility>
15+
</assembly>

0 commit comments

Comments
 (0)