Skip to content

Commit 80f92cf

Browse files
committed
src: refactor SSLError case statement
- Don't use both break and return simultaneously. - Use case:/UNREACHABLE() to enforce that all cases are handled, instead of CHECK(). PR-URL: #25861 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent ddd6c21 commit 80f92cf

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/tls_wrap.cc

+9-6
Original file line numberDiff line numberDiff line change
@@ -349,14 +349,14 @@ Local<Value> TLSWrap::GetSSLError(int status, int* err, std::string* msg) {
349349
case SSL_ERROR_WANT_READ:
350350
case SSL_ERROR_WANT_WRITE:
351351
case SSL_ERROR_WANT_X509_LOOKUP:
352-
break;
352+
return Local<Value>();
353+
353354
case SSL_ERROR_ZERO_RETURN:
354355
return scope.Escape(env()->zero_return_string());
355-
break;
356-
default:
357-
{
358-
CHECK(*err == SSL_ERROR_SSL || *err == SSL_ERROR_SYSCALL);
359356

357+
case SSL_ERROR_SSL:
358+
case SSL_ERROR_SYSCALL:
359+
{
360360
unsigned long ssl_err = ERR_peek_error(); // NOLINT(runtime/int)
361361
BIO* bio = BIO_new(BIO_s_mem());
362362
ERR_print_errors(bio);
@@ -409,8 +409,11 @@ Local<Value> TLSWrap::GetSSLError(int status, int* err, std::string* msg) {
409409

410410
return scope.Escape(exception);
411411
}
412+
413+
default:
414+
UNREACHABLE();
412415
}
413-
return Local<Value>();
416+
UNREACHABLE();
414417
}
415418

416419

0 commit comments

Comments
 (0)