Skip to content

Commit 82e71dd

Browse files
apapirovskirvagg
authored andcommitted
src: fix integer overflow in GetNow
PR-URL: #22214 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent fcca2f7 commit 82e71dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/env.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ Local<Value> Environment::GetNow() {
536536
CHECK_GE(now, timer_base());
537537
now -= timer_base();
538538
if (now <= 0xffffffff)
539-
return Integer::New(isolate(), static_cast<uint32_t>(now));
539+
return Integer::NewFromUnsigned(isolate(), static_cast<uint32_t>(now));
540540
else
541541
return Number::New(isolate(), static_cast<double>(now));
542542
}

0 commit comments

Comments
 (0)