Skip to content

Commit 832ea52

Browse files
richardlauBridgeAR
authored andcommitted
build: remove .git folders when testing V8
When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32877 Refs: nodejs/build#2256 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 4baf41f commit 832ea52

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/make-v8.sh

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ BUILD_ARCH_TYPE=$1
44
V8_BUILD_OPTIONS=$2
55

66
cd deps/v8
7+
find . -type d -name .git | xargs rm -rf
78
tools/node/fetch_deps.py .
89

910
ARCH="`arch`"

0 commit comments

Comments
 (0)