Skip to content

Commit 8393ebc

Browse files
RafaelGSSjuanarbol
authored andcommitted
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
Backport-PR-URL: nodejs-private/node-private#379 CVE-ID: CVE-2023-23920 PR-URL: nodejs-private/node-private#374 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 004e34d commit 8393ebc

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

configure.py

+3
Original file line numberDiff line numberDiff line change
@@ -1722,6 +1722,9 @@ def icu_download(path):
17221722
# always set icu_small, node.gyp depends on it being defined.
17231723
o['variables']['icu_small'] = b(False)
17241724

1725+
# prevent data override
1726+
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
1727+
17251728
with_intl = options.with_intl
17261729
with_icu_source = options.with_icu_source
17271730
have_icu_path = bool(options.with_icu_path)

0 commit comments

Comments
 (0)