Skip to content

Commit 84249df

Browse files
Trotttargos
authored andcommitted
test: make test-uv-binding-constant JS engine neutral
The error message validation in test-uv-binding-constant depends on the JS engine. The text will be different in node-chakracore than in V8-based versions of Node.js. Remove the message validation. Test that it is a TypeError only. We should only validate error messages when we control the contents of that error message (and not even necessarily then, but that is a minimum requirement). V8 and other underlying engines can change the error message at any time and that should not require us to change our tests (as changing tests suggests a semver-major change). PR-URL: #24666 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 3288c27 commit 84249df

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/parallel/test-uv-binding-constant.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ const keys = Object.keys(uv);
1313
keys.forEach((key) => {
1414
if (key.startsWith('UV_')) {
1515
const val = uv[key];
16-
assert.throws(() => uv[key] = 1,
17-
/^TypeError: Cannot assign to read only property/);
16+
assert.throws(() => uv[key] = 1, TypeError);
1817
assert.strictEqual(uv[key], val);
1918
}
2019
});

0 commit comments

Comments
 (0)