Skip to content

Commit 8476ffb

Browse files
aduh95targos
authored andcommitted
test: use assert.match() instead of assert(regex.test())
PR-URL: #42803 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
1 parent c32f76d commit 8476ffb

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

test/parallel/test-runner-cli.js

+18-18
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const testFixtures = fixtures.path('test-runner');
1414
assert.strictEqual(child.status, 1);
1515
assert.strictEqual(child.signal, null);
1616
assert.strictEqual(child.stdout.toString(), '');
17-
assert(/^Could not find/.test(child.stderr.toString()));
17+
assert.match(child.stderr.toString(), /^Could not find/);
1818
}
1919

2020
{
@@ -27,11 +27,11 @@ const testFixtures = fixtures.path('test-runner');
2727
assert.strictEqual(child.signal, null);
2828
assert.strictEqual(child.stderr.toString(), '');
2929
const stdout = child.stdout.toString();
30-
assert(/ok 1 - .+index\.test\.js/.test(stdout));
31-
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
32-
assert(/not ok 1 - this should fail/.test(stdout));
33-
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
34-
assert(/ok 4 - .+random\.cjs/.test(stdout));
30+
assert.match(stdout, /ok 1 - .+index\.test\.js/);
31+
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
32+
assert.match(stdout, /not ok 1 - this should fail/);
33+
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
34+
assert.match(stdout, /ok 4 - .+random\.cjs/);
3535
}
3636

3737
{
@@ -43,11 +43,11 @@ const testFixtures = fixtures.path('test-runner');
4343
assert.strictEqual(child.signal, null);
4444
assert.strictEqual(child.stderr.toString(), '');
4545
const stdout = child.stdout.toString();
46-
assert(/not ok 1 - .+index\.js/.test(stdout));
47-
assert(/ok 2 - .+index\.test\.js/.test(stdout));
48-
assert(/not ok 3 - .+random\.test\.mjs/.test(stdout));
49-
assert(/not ok 1 - this should fail/.test(stdout));
50-
assert(/ok 4 - .+subdir.+subdir_test\.js/.test(stdout));
46+
assert.match(stdout, /not ok 1 - .+index\.js/);
47+
assert.match(stdout, /ok 2 - .+index\.test\.js/);
48+
assert.match(stdout, /not ok 3 - .+random\.test\.mjs/);
49+
assert.match(stdout, /not ok 1 - this should fail/);
50+
assert.match(stdout, /ok 4 - .+subdir.+subdir_test\.js/);
5151
}
5252

5353
{
@@ -59,7 +59,7 @@ const testFixtures = fixtures.path('test-runner');
5959
assert.strictEqual(child.signal, null);
6060
assert.strictEqual(child.stderr.toString(), '');
6161
const stdout = child.stdout.toString();
62-
assert(/not ok 1 - .+test-nm\.js/.test(stdout));
62+
assert.match(stdout, /not ok 1 - .+test-nm\.js/);
6363
}
6464

6565
{
@@ -72,11 +72,11 @@ const testFixtures = fixtures.path('test-runner');
7272
assert.strictEqual(child.signal, null);
7373
assert.strictEqual(child.stderr.toString(), '');
7474
const stdout = child.stdout.toString();
75-
assert(/ok 1 - .+index\.test\.js/.test(stdout));
76-
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
77-
assert(/not ok 1 - this should fail/.test(stdout));
78-
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
79-
assert(/ok 4 - .+random\.cjs/.test(stdout));
75+
assert.match(stdout, /ok 1 - .+index\.test\.js/);
76+
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
77+
assert.match(stdout, /not ok 1 - this should fail/);
78+
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
79+
assert.match(stdout, /ok 4 - .+random\.cjs/);
8080
}
8181

8282
{
@@ -102,6 +102,6 @@ const testFixtures = fixtures.path('test-runner');
102102
assert.strictEqual(child.signal, null);
103103
assert.strictEqual(child.stdout.toString(), '');
104104
const stderr = child.stderr.toString();
105-
assert(/--test/.test(stderr));
105+
assert.match(stderr, /--test/);
106106
});
107107
}

0 commit comments

Comments
 (0)