Skip to content

Commit 84d455e

Browse files
committed
deps: make V8 compilable with older glibc
Remove call to `memfd_create`. The function that references it is only used for V8 testing. PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 0cc81f0 commit 84d455e

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/base/platform/platform-posix.cc

-19
Original file line numberDiff line numberDiff line change
@@ -618,26 +618,7 @@ void OS::FreeAddressSpaceReservation(AddressSpaceReservation reservation) {
618618
// Need to disable CFI_ICALL due to the indirect call to memfd_create.
619619
DISABLE_CFI_ICALL
620620
PlatformSharedMemoryHandle OS::CreateSharedMemoryHandleForTesting(size_t size) {
621-
#if V8_OS_LINUX && !V8_OS_ANDROID
622-
// Use memfd_create if available, otherwise mkstemp.
623-
using memfd_create_t = int (*)(const char*, unsigned int);
624-
memfd_create_t memfd_create =
625-
reinterpret_cast<memfd_create_t>(dlsym(RTLD_DEFAULT, "memfd_create"));
626-
int fd = -1;
627-
if (memfd_create) {
628-
fd = memfd_create("V8MemFDForTesting", 0);
629-
}
630-
if (fd == -1) {
631-
char filename[] = "/tmp/v8_tmp_file_for_testing_XXXXXX";
632-
fd = mkstemp(filename);
633-
if (fd != -1) CHECK_EQ(0, unlink(filename));
634-
}
635-
if (fd == -1) return kInvalidSharedMemoryHandle;
636-
CHECK_EQ(0, ftruncate(fd, size));
637-
return SharedMemoryHandleFromFileDescriptor(fd);
638-
#else
639621
return kInvalidSharedMemoryHandle;
640-
#endif
641622
}
642623

643624
// static

0 commit comments

Comments
 (0)