Skip to content

Commit 84e5807

Browse files
codebyteretargos
authored andcommittedNov 2, 2018
src: fix CreatePlatform header param mismatch
PR-URL: #23947 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
1 parent 38b0525 commit 84e5807

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed
 

‎src/node.h

+7-6
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,16 @@
100100
// Forward-declare libuv loop
101101
struct uv_loop_s;
102102

103-
// Forward-declare TracingController, used by CreatePlatform.
104-
namespace v8 {
105-
class TracingController;
106-
}
107-
108103
// Forward-declare these functions now to stop MSVS from becoming
109104
// terminally confused when it's done in node_internals.h
110105
namespace node {
111106

107+
namespace tracing {
108+
109+
class TracingController;
110+
111+
}
112+
112113
NODE_EXTERN v8::Local<v8::Value> ErrnoException(v8::Isolate* isolate,
113114
int errorno,
114115
const char* syscall = nullptr,
@@ -275,7 +276,7 @@ NODE_EXTERN MultiIsolatePlatform* GetMainThreadMultiIsolatePlatform();
275276

276277
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
277278
int thread_pool_size,
278-
v8::TracingController* tracing_controller);
279+
node::tracing::TracingController* tracing_controller);
279280
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size);
280281
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform);
281282

0 commit comments

Comments
 (0)