Skip to content

Commit 85aa030

Browse files
Trotttargos
authored andcommitted
doc: revise accepting-modifications in guide
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: #24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent 99dbdca commit 85aa030

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

COLLABORATOR_GUIDE.md

+4-6
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the
9393

9494
## Accepting Modifications
9595

96-
All modifications to the Node.js code and documentation should be performed via
97-
GitHub pull requests, including modifications by Collaborators and TSC members.
98-
A pull request must be reviewed, and must also be tested with CI, before being
99-
landed into the codebase. There may be exceptions to the latter (the changed
100-
code cannot be tested with a CI or similar). If that is the case, please leave a
101-
comment that explains why the PR does not require a CI run.
96+
Contributors propose modifications to Node.js using GitHub pull requests. This
97+
is true for all modifications including those proposed by TSC members and other
98+
Collaborators. A pull request must pass code review and CI before landing into
99+
the codebase.
102100

103101
### Code Reviews
104102

0 commit comments

Comments
 (0)