Skip to content

Commit 8713c83

Browse files
authored
src: remove dead comments about return_code_cache
This behavior of sometimes returning the function & other times returning the code cache was removed a long time ago in the referenced PR, as evinced by the return type `MaybeLocal<Function>`. Remove these incorrect comments. Refs: #24950 PR-URL: #47083 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 2566400 commit 8713c83

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/node_builtins.cc

-6
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,6 @@ bool BuiltinLoader::Add(const char* id, std::string_view utf8source) {
253253
return Add(id, UnionBytes(out));
254254
}
255255

256-
// Returns Local<Function> of the compiled module if return_code_cache
257-
// is false (we are only compiling the function).
258-
// Otherwise return a Local<Object> containing the cache.
259256
MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
260257
Local<Context> context,
261258
const char* id,
@@ -353,9 +350,6 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
353350
return scope.Escape(fun);
354351
}
355352

356-
// Returns Local<Function> of the compiled module if return_code_cache
357-
// is false (we are only compiling the function).
358-
// Otherwise return a Local<Object> containing the cache.
359353
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
360354
const char* id,
361355
Realm* optional_realm) {

0 commit comments

Comments
 (0)