Skip to content

Commit 8887666

Browse files
LPGhatguyjoaocgreis
authored andcommitted
build: update manifest to include Windows 10
This is a port of b0dd3bf . Original commit message: Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: #2332 Reviewed-By: Roman Reiss <me@silverwind.io> PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
1 parent 08afe4e commit 8887666

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/res/node.exe.extra.manifest

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
33
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
44
<application>
5+
<!-- Windows 10 -->
6+
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
57
<!-- Windows 8.1 -->
68
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
79
<!-- Windows 8 -->

0 commit comments

Comments
 (0)