Skip to content

Commit 89a5d04

Browse files
lpincaMoLow
authored andcommitted
doc: do not create a backup file
The `sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h` command creates a `zconf.h--` backup file on macOS. Replace it with an equivalent perl one-liner so that it works on both Linux and macOS. PR-URL: #47151 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 443a72e commit 89a5d04

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

doc/contributing/maintaining-zlib.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ mv zlib deps/
1515
mv deps/zlib.gyp deps/GN-scraper.py deps/zlib/
1616
mkdir deps/zlib/win32
1717
mv deps/zlib.def deps/zlib/win32
18-
sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h
18+
perl -i -pe 's|^#include "chromeconf.h"|//#include "chromeconf.h"|' deps/zlib/zconf.h
1919
```
2020

2121
Check that Node.js still builds and tests.

0 commit comments

Comments
 (0)