Skip to content

Commit 89d1eb5

Browse files
fossamagnadanielleadams
authored andcommitted
build: add --v8-disable-object-print flag
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: #45433 PR-URL: #45458 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 43419ad commit 89d1eb5

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

configure.py

+12-2
Original file line numberDiff line numberDiff line change
@@ -805,7 +805,13 @@
805805
action='store_true',
806806
dest='v8_enable_object_print',
807807
default=True,
808-
help='compile V8 with auxiliar functions for native debuggers')
808+
help='compile V8 with auxiliary functions for native debuggers')
809+
810+
parser.add_argument('--v8-disable-object-print',
811+
action='store_true',
812+
dest='v8_disable_object_print',
813+
default=False,
814+
help='disable the V8 auxiliary functions for native debuggers')
809815

810816
parser.add_argument('--v8-enable-hugepage',
811817
action='store_true',
@@ -1490,7 +1496,7 @@ def configure_v8(o):
14901496
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
14911497
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
14921498
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
1493-
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
1499+
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1
14941500
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
14951501
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
14961502
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
@@ -1513,6 +1519,10 @@ def configure_v8(o):
15131519
o['variables']['v8_enable_hugepage'] = 1 if options.v8_enable_hugepage else 0
15141520
if options.v8_enable_short_builtin_calls or o['variables']['target_arch'] == 'x64':
15151521
o['variables']['v8_enable_short_builtin_calls'] = 1
1522+
if options.v8_enable_object_print and options.v8_disable_object_print:
1523+
raise Exception(
1524+
'Only one of the --v8-enable-object-print or --v8-disable-object-print options '
1525+
'can be specified at a time.')
15161526

15171527
def configure_openssl(o):
15181528
variables = o['variables']

0 commit comments

Comments
 (0)