Skip to content

Commit 8a4cd4c

Browse files
committed
doc: revise CI text in collaborator guide
Minor clarifications to text. For example, this moves the "(green or yellow)" parenthetical closer to the text to which it applies. (It applies only to Jenkins CI.)
1 parent 5c3bc21 commit 8a4cd4c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

doc/guides/collaborator-guide.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,11 @@ the comment anyway to avoid any doubt.
209209
All fixes must have a test case which demonstrates the defect. The test should
210210
fail before the change, and pass after the change.
211211

212-
Do not land any pull requests without a passing (green or yellow) CI run.
213-
A green GitHub Actions CI result is required. A passing
214-
[Jenkins CI](https://ci.nodejs.org/) is also required if PR contains changes
215-
that will affect the `node` binary. This is critical as GitHub Actions CI does
216-
not cover all the environments supported by Node.js.
212+
Do not land any pull requests without the necessary passing CI runs.
213+
A passing (green) GitHub Actions CI result is required. A passing (green or
214+
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
215+
request contains changes that will affect the `node` binary. This is because
216+
GitHub Actions CI does not cover all the environments supported by Node.js.
217217

218218
<details>
219219
<summary>Changes that affect the `node` binary</summary>
@@ -294,7 +294,7 @@ in the form:
294294
To specify the branch this way, `refs/heads/BRANCH` is used
295295
(e.g. for `master` -> `refs/heads/master`).
296296
For pull requests, it will look like `refs/pull/PR_NUMBER/head`
297-
(e.g. for PR#42 -> `refs/pull/42/head`).
297+
(e.g. for pull request #42 -> `refs/pull/42/head`).
298298
* `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased
299299
onto master. This can especially be important for pull requests that have been
300300
open a while.

0 commit comments

Comments
 (0)