Skip to content

Commit 8a91fc1

Browse files
Jayasankar-mrvagg
authored andcommitted
src: elevate v8 namespaces for node_url.cc
Elevate namespace for repeated entities. PR-URL: #24573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 54778a0 commit 8a91fc1

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/node_url.cc

+7-6
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ using v8::Integer;
2121
using v8::Isolate;
2222
using v8::Local;
2323
using v8::MaybeLocal;
24+
using v8::NewStringType;
2425
using v8::Null;
2526
using v8::Object;
2627
using v8::String;
@@ -31,7 +32,7 @@ using v8::Value;
3132
inline Local<String> Utf8String(Isolate* isolate, const std::string& str) {
3233
return String::NewFromUtf8(isolate,
3334
str.data(),
34-
v8::NewStringType::kNormal,
35+
NewStringType::kNormal,
3536
str.length()).ToLocalChecked();
3637
}
3738

@@ -2159,7 +2160,7 @@ static void Parse(Environment* env,
21592160
argv[ERR_ARG_INPUT] =
21602161
String::NewFromUtf8(env->isolate(),
21612162
input,
2162-
v8::NewStringType::kNormal).ToLocalChecked();
2163+
NewStringType::kNormal).ToLocalChecked();
21632164
error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv)
21642165
.FromMaybe(Local<Value>());
21652166
}
@@ -2209,7 +2210,7 @@ static void EncodeAuthSet(const FunctionCallbackInfo<Value>& args) {
22092210
args.GetReturnValue().Set(
22102211
String::NewFromUtf8(env->isolate(),
22112212
output.c_str(),
2212-
v8::NewStringType::kNormal).ToLocalChecked());
2213+
NewStringType::kNormal).ToLocalChecked());
22132214
}
22142215

22152216
static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
@@ -2243,7 +2244,7 @@ static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
22432244
args.GetReturnValue().Set(
22442245
String::NewFromTwoByte(env->isolate(),
22452246
*value,
2246-
v8::NewStringType::kNormal,
2247+
NewStringType::kNormal,
22472248
n).ToLocalChecked());
22482249
}
22492250

@@ -2264,7 +2265,7 @@ static void DomainToASCII(const FunctionCallbackInfo<Value>& args) {
22642265
args.GetReturnValue().Set(
22652266
String::NewFromUtf8(env->isolate(),
22662267
out.c_str(),
2267-
v8::NewStringType::kNormal).ToLocalChecked());
2268+
NewStringType::kNormal).ToLocalChecked());
22682269
}
22692270

22702271
static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
@@ -2284,7 +2285,7 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
22842285
args.GetReturnValue().Set(
22852286
String::NewFromUtf8(env->isolate(),
22862287
out.c_str(),
2287-
v8::NewStringType::kNormal).ToLocalChecked());
2288+
NewStringType::kNormal).ToLocalChecked());
22882289
}
22892290

22902291
std::string URL::ToFilePath() const {

0 commit comments

Comments
 (0)