Skip to content

Commit 8e18979

Browse files
committedAug 31, 2018
test: remove skip of OS X bug
Three tests are skipped because of Applie bug 17894467. That bug exists in OS X 10.10, but we no longer support 10.10 (and neither does Apple). Remove the test-skipping. PR-URL: #22546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 366ffdc commit 8e18979

3 files changed

+0
-7
lines changed
 

‎test/parallel/test-dgram-send-empty-array.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
const common = require('../common');
44

5-
if (common.isOSX)
6-
common.skip('because of 17894467 Apple bug');
7-
85
const assert = require('assert');
96
const dgram = require('dgram');
107

‎test/parallel/test-dgram-send-empty-buffer.js

-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121

2222
'use strict';
2323
const common = require('../common');
24-
if (common.isOSX)
25-
common.skip('because of 17894467 Apple bug');
2624

2725
const assert = require('assert');
2826
const dgram = require('dgram');

‎test/parallel/test-dgram-send-empty-packet.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
'use strict';
22
const common = require('../common');
3-
if (common.isOSX)
4-
common.skip('because of 17894467 Apple bug');
53

64
const assert = require('assert');
75
const dgram = require('dgram');

0 commit comments

Comments
 (0)