Skip to content

Commit 8e268c7

Browse files
committed
test: fix common.PIPE path bug
`common.PIPE` is returning a path name in `test` rather than in the `tmp` directory for each test. This is causing multiple test failures in CI. Make the path name inside the temporary directories again. This way the pipe is removed by `common.refreshTmpDir()` on POSIX. The bug in `common.PIPE` was introduced in c34ae48. PR-URL: #16364 Fixes: #16290 Fixes: #16323 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent fe4675b commit 8e268c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/common/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', {
274274
const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`);
275275
const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative;
276276
const pipeName = `node-test.${process.pid}.sock`;
277-
exports.PIPE = pipePrefix + pipeName;
277+
exports.PIPE = path.join(pipePrefix, pipeName);
278278
}
279279

280280
{

0 commit comments

Comments
 (0)