Skip to content

Commit 8e8fac2

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: fix -Winconsistent-missing-override warning
Fix a compiler warning that was introduced in commit 4db1bc8 ("http2: allocate on every chunk send") by adding an `override` keyword. PR-URL: #16726 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 99d775c commit 8e8fac2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_http2.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ class Http2Session : public AsyncWrap,
444444
const SubmitTrailers& submit_trailers) override;
445445

446446
void Send(WriteWrap* req, char* buf, size_t length) override;
447-
WriteWrap* AllocateSend();
447+
WriteWrap* AllocateSend() override;
448448

449449
int DoWrite(WriteWrap* w, uv_buf_t* bufs, size_t count,
450450
uv_stream_t* send_handle) override;

0 commit comments

Comments
 (0)