Skip to content

Commit 90aac7c

Browse files
thefourtheyeevanlucas
authored andcommitted
build: start comments at beginning of line
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4bb9d21 commit 90aac7c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ test/addons/.buildstamp: config.gypi \
163163
deps/uv/include/*.h deps/v8/include/*.h \
164164
src/node.h src/node_buffer.h src/node_object_wrap.h src/node_version.h \
165165
test/addons/.docbuildstamp
166-
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
167-
# embedded addons have been generated from the documentation.
166+
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
167+
# embedded addons have been generated from the documentation.
168168
for dirname in test/addons/*/; do \
169169
echo "\nRunning addons test $$PWD/$$dirname" ; \
170170
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
@@ -262,15 +262,15 @@ test-timers-clean:
262262

263263
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
264264
test-v8: v8
265-
# note: performs full test unless QUICKCHECK is specified
265+
# note: performs full test unless QUICKCHECK is specified
266266
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
267267
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
268268
--no-presubmit \
269269
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
270270
$(TAP_V8)
271271

272272
test-v8-intl: v8
273-
# note: performs full test unless QUICKCHECK is specified
273+
# note: performs full test unless QUICKCHECK is specified
274274
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
275275
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
276276
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
@@ -283,7 +283,7 @@ test-v8-benchmarks: v8
283283
$(TAP_V8_BENCHMARKS)
284284

285285
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
286-
# runs all v8 tests
286+
# runs all v8 tests
287287
else
288288
test-v8 test-v8-intl test-v8-benchmarks test-v8-all:
289289
@echo "Testing v8 is not available through the source tarball."

0 commit comments

Comments
 (0)