Skip to content

Commit 925e58f

Browse files
JLHwungMylesBorins
authored andcommitted
fs: fix stat dev unsigned cast overflow
The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow PR-URL: #16705 Fixes: #16496 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent f0eeddb commit 925e58f

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/node_file.cc

-8
Original file line numberDiff line numberDiff line change
@@ -451,14 +451,6 @@ Local<Value> BuildStatsObject(Environment* env, const uv_stat_t* s) {
451451
# else
452452
Local<Value> blksize = Undefined(env->isolate());
453453
# endif
454-
#undef X
455-
456-
// Integers.
457-
#define X(name) \
458-
Local<Value> name = Integer::New(env->isolate(), s->st_##name); \
459-
if (name.IsEmpty()) \
460-
return Local<Object>(); \
461-
462454
X(dev)
463455
X(mode)
464456
X(nlink)

0 commit comments

Comments
 (0)