Commit 931174f 1 parent a99fb54 commit 931174f Copy full SHA for 931174f
File tree 3 files changed +5
-15
lines changed
3 files changed +5
-15
lines changed Original file line number Diff line number Diff line change @@ -305,7 +305,6 @@ in the placeholder's `README`.
305
305
For pull requests introducing new core modules:
306
306
307
307
* Allow at least one week for review.
308
- * Label with the ` tsc-review ` label.
309
308
* Land only after sign-off from at least two TSC members.
310
309
* Land with a [ Stability Index] [ ] of Experimental. The module must remain
311
310
Experimental until a semver-major release.
@@ -381,9 +380,8 @@ Do this if a pull request or issue:
381
380
- is controversial, or
382
381
- is at an impasse among Collaborators who are participating in the discussion.
383
382
384
- Assign the ` tsc-review ` label or @-mention the
385
- ` @nodejs/tsc ` GitHub team if you want to elevate an issue to the [ TSC] [ ] .
386
- Do not use the GitHub UI on the right-hand side to assign to
383
+ @-mention the ` @nodejs/tsc ` GitHub team if you want to elevate an issue to the
384
+ [ TSC] [ ] . Do not use the GitHub UI on the right-hand side to assign to
387
385
` @nodejs/tsc ` or request a review from ` @nodejs/tsc ` .
388
386
389
387
The TSC should serve as the final arbiter where required.
Original file line number Diff line number Diff line change @@ -50,10 +50,6 @@ be accepted unless:
50
50
This should only happen if disagreements between Collaborators cannot be
51
51
resolved through discussion.
52
52
53
- Collaborators may opt to elevate significant or controversial modifications to
54
- the TSC by assigning the ` tsc-review ` label to a pull request or issue. The
55
- TSC should serve as the final arbiter where required.
56
-
57
53
See:
58
54
59
55
* [ Current list of Collaborators] ( ./README.md#current-project-team-members )
@@ -105,11 +101,9 @@ The intention of the agenda is not to approve or review all patches.
105
101
That should happen continuously on GitHub and be handled by the larger
106
102
group of Collaborators.
107
103
108
- Any community member or contributor can ask that something be reviewed
109
- by the TSC by logging a GitHub issue. Any Collaborator, TSC member, or the
110
- meeting chair can bring the issue to the TSC's attention by applying the
111
- ` tsc-review ` label. If consensus-seeking among TSC members fails for a
112
- particular issue, it may be added to the TSC meeting agenda by adding the
104
+ Any community member or contributor can ask that something be reviewed by the
105
+ TSC by logging a GitHub issue. If consensus-seeking among TSC members fails for
106
+ a particular issue, it may be added to the TSC meeting agenda by adding the
113
107
` tsc-agenda ` label.
114
108
115
109
Prior to each TSC meeting, the meeting chair will share the agenda with
Original file line number Diff line number Diff line change @@ -89,8 +89,6 @@ onboarding session.
89
89
so that we know what parts of the code base the pull request modifies. It is
90
90
not perfect, of course. Feel free to apply relevant labels and remove
91
91
irrelevant labels from pull requests and issues.
92
- * Use the ` tsc-review ` label if a topic is controversial or isn't coming to a
93
- conclusion after an extended time.
94
92
* ` semver-{minor,major} ` :
95
93
* If a change has the remote * chance* of breaking something, use the
96
94
` semver-major ` label
You can’t perform that action at this time.
0 commit comments