Skip to content

Commit 931174f

Browse files
TrottBridgeAR
authored andcommitted
doc: remove tsc-review
The tsc-review label is ineffective. It almost always gets ignored. Remove it. When requiring TSC attention, people should @-mention the TSC GitHub team. PR-URL: #26506 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent a99fb54 commit 931174f

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

COLLABORATOR_GUIDE.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ in the placeholder's `README`.
305305
For pull requests introducing new core modules:
306306

307307
* Allow at least one week for review.
308-
* Label with the `tsc-review` label.
309308
* Land only after sign-off from at least two TSC members.
310309
* Land with a [Stability Index][] of Experimental. The module must remain
311310
Experimental until a semver-major release.
@@ -381,9 +380,8 @@ Do this if a pull request or issue:
381380
- is controversial, or
382381
- is at an impasse among Collaborators who are participating in the discussion.
383382

384-
Assign the `tsc-review` label or @-mention the
385-
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
386-
Do not use the GitHub UI on the right-hand side to assign to
383+
@-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the
384+
[TSC][]. Do not use the GitHub UI on the right-hand side to assign to
387385
`@nodejs/tsc` or request a review from `@nodejs/tsc`.
388386

389387
The TSC should serve as the final arbiter where required.

GOVERNANCE.md

+3-9
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ be accepted unless:
5050
This should only happen if disagreements between Collaborators cannot be
5151
resolved through discussion.
5252

53-
Collaborators may opt to elevate significant or controversial modifications to
54-
the TSC by assigning the `tsc-review` label to a pull request or issue. The
55-
TSC should serve as the final arbiter where required.
56-
5753
See:
5854

5955
* [Current list of Collaborators](./README.md#current-project-team-members)
@@ -105,11 +101,9 @@ The intention of the agenda is not to approve or review all patches.
105101
That should happen continuously on GitHub and be handled by the larger
106102
group of Collaborators.
107103

108-
Any community member or contributor can ask that something be reviewed
109-
by the TSC by logging a GitHub issue. Any Collaborator, TSC member, or the
110-
meeting chair can bring the issue to the TSC's attention by applying the
111-
`tsc-review` label. If consensus-seeking among TSC members fails for a
112-
particular issue, it may be added to the TSC meeting agenda by adding the
104+
Any community member or contributor can ask that something be reviewed by the
105+
TSC by logging a GitHub issue. If consensus-seeking among TSC members fails for
106+
a particular issue, it may be added to the TSC meeting agenda by adding the
113107
`tsc-agenda` label.
114108

115109
Prior to each TSC meeting, the meeting chair will share the agenda with

doc/onboarding.md

-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ onboarding session.
8989
so that we know what parts of the code base the pull request modifies. It is
9090
not perfect, of course. Feel free to apply relevant labels and remove
9191
irrelevant labels from pull requests and issues.
92-
* Use the `tsc-review` label if a topic is controversial or isn't coming to a
93-
conclusion after an extended time.
9492
* `semver-{minor,major}`:
9593
* If a change has the remote *chance* of breaking something, use the
9694
`semver-major` label

0 commit comments

Comments
 (0)