module: fix ERR_REQUIRE_ESM error for null frames

guybedford · targos · commit 93bbaa0ce9bc · 2021-08-02T19:37:50.000+02:00
PR-URL: #39593 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -808,7 +808,7 @@ function hideInternalStackFrames(error) {
     if (typeof stackFrames === 'object') {
       frames = ArrayPrototypeFilter(
         stackFrames,
-        (frm) => !StringPrototypeStartsWith(frm.getFileName(),
+        (frm) => !StringPrototypeStartsWith(frm.getFileName() || '',
                                             'node:internal')
       );
     }
diff --git a/test/fixtures/es-modules/cjs-esm.js b/test/fixtures/es-modules/cjs-esm.js
@@ -1 +1 @@
-require('./package-type-module/cjs.js');
+eval("require('./package-type-module/cjs.js')");

Original file line number	Diff line number	Diff line change
`@@ -808,7 +808,7 @@ function hideInternalStackFrames(error) {`
`808`	`808`	`if (typeof stackFrames === 'object') {`
`809`	`809`	`frames = ArrayPrototypeFilter(`
`810`	`810`	`stackFrames,`
`811`		`- (frm) => !StringPrototypeStartsWith(frm.getFileName(),`
	`811`	`+ (frm) => !StringPrototypeStartsWith(frm.getFileName() \|\| '',`
`812`	`812`	`'node:internal')`
`813`	`813`	`);`
`814`	`814`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-require('./package-type-module/cjs.js');`
	`1`	`+eval("require('./package-type-module/cjs.js')");`