Skip to content

Commit 94aa291

Browse files
committed
quic: clarify TODO statements
PR-URL: #34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 19e712b commit 94aa291

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/quic/node_quic_session.cc

+10
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,16 @@ void QuicSessionConfig::Set(
263263
// TODO(@jasnell): QUIC allows both IPv4 and IPv6 addresses to be
264264
// specified. Here we're specifying one or the other. Need to
265265
// determine if that's what we want or should we support both.
266+
//
267+
// TODO(@jasnell): Currently, this is specified as a single value
268+
// that is used for all connections. In the future, it may be
269+
// necessary to determine the preferred address based on the
270+
// remote address. The trick, however, is that the preferred
271+
// address must be selected before the QuicSession is created,
272+
// before the handshake can be started. That is, it may need
273+
// to be an optional callback on QuicSocket. That would incur
274+
// a performance penalty so we'd really have to be sure of the
275+
// utility.
266276
if (preferred_addr != nullptr) {
267277
transport_params.preferred_address_present = 1;
268278
switch (preferred_addr->sa_family) {

0 commit comments

Comments
 (0)