Skip to content

Commit 94dd7b9

Browse files
ktrantargos
authored andcommitted
test: update tests after increasing typed array size to 4GB
PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent faeb960 commit 94dd7b9

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

test/parallel/test-buffer-alloc.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22
const common = require('../common');
3+
34
const assert = require('assert');
45
const vm = require('vm');
56

@@ -8,8 +9,8 @@ const SlowBuffer = require('buffer').SlowBuffer;
89
// Verify the maximum Uint8Array size. There is no concrete limit by spec. The
910
// internal limits should be updated if this fails.
1011
assert.throws(
11-
() => new Uint8Array(2 ** 32),
12-
{ message: 'Invalid typed array length: 4294967296' }
12+
() => new Uint8Array(2 ** 32 + 1),
13+
{ message: 'Invalid typed array length: 4294967297' }
1314
);
1415

1516
const b = Buffer.allocUnsafe(1024);
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22
require('../common');
3+
34
const assert = require('assert');
45

56
const buffer = require('buffer');
@@ -12,11 +13,11 @@ const bufferMaxSizeMsg = {
1213
message: /^The argument 'size' is invalid\. Received [^"]*$/
1314
};
1415

15-
assert.throws(() => Buffer((-1 >>> 0) + 1), bufferMaxSizeMsg);
16-
assert.throws(() => SlowBuffer((-1 >>> 0) + 1), bufferMaxSizeMsg);
17-
assert.throws(() => Buffer.alloc((-1 >>> 0) + 1), bufferMaxSizeMsg);
18-
assert.throws(() => Buffer.allocUnsafe((-1 >>> 0) + 1), bufferMaxSizeMsg);
19-
assert.throws(() => Buffer.allocUnsafeSlow((-1 >>> 0) + 1), bufferMaxSizeMsg);
16+
assert.throws(() => Buffer((-1 >>> 0) + 2), bufferMaxSizeMsg);
17+
assert.throws(() => SlowBuffer((-1 >>> 0) + 2), bufferMaxSizeMsg);
18+
assert.throws(() => Buffer.alloc((-1 >>> 0) + 2), bufferMaxSizeMsg);
19+
assert.throws(() => Buffer.allocUnsafe((-1 >>> 0) + 2), bufferMaxSizeMsg);
20+
assert.throws(() => Buffer.allocUnsafeSlow((-1 >>> 0) + 2), bufferMaxSizeMsg);
2021

2122
assert.throws(() => Buffer(kMaxLength + 1), bufferMaxSizeMsg);
2223
assert.throws(() => SlowBuffer(kMaxLength + 1), bufferMaxSizeMsg);
@@ -25,5 +26,5 @@ assert.throws(() => Buffer.allocUnsafe(kMaxLength + 1), bufferMaxSizeMsg);
2526
assert.throws(() => Buffer.allocUnsafeSlow(kMaxLength + 1), bufferMaxSizeMsg);
2627

2728
// issue GH-4331
28-
assert.throws(() => Buffer.allocUnsafe(0x100000000), bufferMaxSizeMsg);
29+
assert.throws(() => Buffer.allocUnsafe(0x100000001), bufferMaxSizeMsg);
2930
assert.throws(() => Buffer.allocUnsafe(0xFFFFFFFFF), bufferMaxSizeMsg);

0 commit comments

Comments
 (0)