Skip to content

Commit 957ceaa

Browse files
TrottBridgeAR
authored andcommitted
test: fix flaky test-vm-timeout-escape-queuemicrotask
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: #24296 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
1 parent 39382ed commit 957ceaa

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

test/known_issues/known_issues.status

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ prefix known_issues
1010

1111
[$system==linux]
1212
test-vm-timeout-escape-promise: PASS,FLAKY
13-
test-vm-timeout-escape-queuemicrotask: PASS,FLAKY
1413

1514
[$system==macos]
1615

test/known_issues/test-vm-timeout-escape-queuemicrotask.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Promises, nextTick, and queueMicrotask allow code to escape the timeout
55
// set for runInContext, runInNewContext, and runInThisContext
66

7-
require('../common');
7+
const common = require('../common');
88
const assert = require('assert');
99
const vm = require('vm');
1010

@@ -32,7 +32,7 @@ assert.throws(() => {
3232
queueMicrotask,
3333
loop
3434
},
35-
{ timeout: 5 }
35+
{ timeout: common.platformTimeout(5) }
3636
);
3737
}, {
3838
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',

0 commit comments

Comments
 (0)