Skip to content

Commit 9603bdf

Browse files
sygmarco-ippolito
authored andcommitted
deps: V8: cherry-pick 26fd1dfa9cd6
Original commit message: [import-attributes] Deprecate 'assert' for dynamic import as well Bug: v8:10958 Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#92123} Refs: v8/v8@26fd1df PR-URL: #55961 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 0660991 commit 9603bdf

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.24',
39+
'v8_embedder_string': '-node.25',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/execution/isolate.cc

+14
Original file line numberDiff line numberDiff line change
@@ -5193,6 +5193,20 @@ MaybeHandle<FixedArray> Isolate::GetImportAssertionsFromArgument(
51935193
// an error.
51945194
return MaybeHandle<FixedArray>();
51955195
}
5196+
5197+
if (V8_UNLIKELY(!import_assertions_object->IsUndefined())) {
5198+
MessageLocation* location = nullptr;
5199+
MessageLocation computed_location;
5200+
if (ComputeLocation(&computed_location)) {
5201+
location = &computed_location;
5202+
}
5203+
Handle<JSMessageObject> message = MessageHandler::MakeMessageObject(
5204+
this, MessageTemplate::kImportAssertDeprecated, location,
5205+
factory()->NewStringFromAsciiChecked("a future version"),
5206+
Handle<FixedArray>::null());
5207+
message->set_error_level(v8::Isolate::kMessageWarning);
5208+
MessageHandler::ReportMessage(this, location, message);
5209+
}
51965210
}
51975211

51985212
// If there is no 'with' or 'assert' option in the options bag, it's not an

0 commit comments

Comments
 (0)