Skip to content

Commit 971af4b

Browse files
committed
quic: fix up coverity warning in quic/session.cc
- add CHECK around SocketAddress::New like we have in other places as suggested by Coverity scan Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #49865 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent c1a3a98 commit 971af4b

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/quic/session.cc

+8-8
Original file line numberDiff line numberDiff line change
@@ -1303,10 +1303,10 @@ void Session::SelectPreferredAddress(PreferredAddress* preferredAddress) {
13031303
auto ipv4 = preferredAddress->ipv4();
13041304
if (ipv4.has_value()) {
13051305
if (ipv4->address.empty() || ipv4->port == 0) return;
1306-
SocketAddress::New(AF_INET,
1307-
std::string(ipv4->address).c_str(),
1308-
ipv4->port,
1309-
&remote_address_);
1306+
CHECK(SocketAddress::New(AF_INET,
1307+
std::string(ipv4->address).c_str(),
1308+
ipv4->port,
1309+
&remote_address_));
13101310
preferredAddress->Use(ipv4.value());
13111311
}
13121312
break;
@@ -1315,10 +1315,10 @@ void Session::SelectPreferredAddress(PreferredAddress* preferredAddress) {
13151315
auto ipv6 = preferredAddress->ipv6();
13161316
if (ipv6.has_value()) {
13171317
if (ipv6->address.empty() || ipv6->port == 0) return;
1318-
SocketAddress::New(AF_INET,
1319-
std::string(ipv6->address).c_str(),
1320-
ipv6->port,
1321-
&remote_address_);
1318+
CHECK(SocketAddress::New(AF_INET,
1319+
std::string(ipv6->address).c_str(),
1320+
ipv6->port,
1321+
&remote_address_));
13221322
preferredAddress->Use(ipv6.value());
13231323
}
13241324
break;

0 commit comments

Comments
 (0)